Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdEmbree] Add a PxrIESFile class which mimics iesFile, with additonal functionality #11

Open
wants to merge 4 commits into
base: pr/hdEmbree-ies-cycles
Choose a base branch
from

Conversation

pmolodo
Copy link

@pmolodo pmolodo commented Jul 31, 2024

Description of Change(s)

  • Add an "eval" method to lookup luminance values for specific directions
  • Calculate total power by integrating over projected solidAngle

NOTE: This chain of PRs was made separate from the PR documenting expected behavior:


  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@pmolodo pmolodo changed the title Add a PxrIESFile class which mimics iesFile, with additonal functionality [hdEmbree] Add a PxrIESFile class which mimics iesFile, with additonal functionality Jul 31, 2024
@pmolodo pmolodo force-pushed the pr/hdEmbree-pxrIES branch from 5f3af3a to 3b9c6a2 Compare August 1, 2024 18:46
@pmolodo pmolodo force-pushed the pr/hdEmbree-ies-cycles branch from c3aa6e4 to 3525a4d Compare August 1, 2024 18:46
@pmolodo pmolodo force-pushed the pr/hdEmbree-ies-cycles branch from 3525a4d to f31c62d Compare September 23, 2024 18:11
@pmolodo pmolodo force-pushed the pr/hdEmbree-pxrIES branch from 3042700 to 7eb43eb Compare October 21, 2024 17:06
@pmolodo pmolodo force-pushed the pr/hdEmbree-ies-cycles branch from f31c62d to 36ddfe3 Compare October 21, 2024 17:06
@pmolodo pmolodo force-pushed the pr/hdEmbree-pxrIES branch from 7eb43eb to 4487922 Compare October 22, 2024 18:11
@pmolodo pmolodo force-pushed the pr/hdEmbree-ies-cycles branch from 36ddfe3 to 48bbdd2 Compare October 22, 2024 18:11
@pmolodo pmolodo force-pushed the pr/hdEmbree-pxrIES branch from 4487922 to be38903 Compare October 23, 2024 17:29
@pmolodo pmolodo force-pushed the pr/hdEmbree-ies-cycles branch from 48bbdd2 to c3c1140 Compare October 23, 2024 17:29
@pmolodo pmolodo force-pushed the pr/hdEmbree-pxrIES branch from be38903 to fd70f4c Compare October 23, 2024 18:19
@pmolodo pmolodo force-pushed the pr/hdEmbree-ies-cycles branch from c3c1140 to 8a6e0ce Compare October 23, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants