[hdEmbree] add support for inputs:diffuse #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
2 tasks
pmolodo
force-pushed
the
pr/hdEmbree-tf-debug-create-light
branch
from
a7f9af6 to
f8d4638
Compare
pmolodo
force-pushed
the
pr/hdEmbree-inputs-diffuse
branch
from
db06d9a to
5c78c8c
Compare
pmolodo
force-pushed
the
pr/hdEmbree-tf-debug-create-light
branch
from
f8d4638 to
1dede61
Compare
pmolodo
force-pushed
the
pr/hdEmbree-inputs-diffuse
branch
from
5c78c8c to
a6e65e2
Compare
pmolodo
force-pushed
the
pr/hdEmbree-inputs-diffuse
branch
from
a6e65e2 to
7dfd37b
Compare
pmolodo
force-pushed
the
pr/hdEmbree-tf-debug-create-light
branch
from
1dede61 to
d33251e
Compare
pmolodo
force-pushed
the
pr/hdEmbree-inputs-diffuse
branch
from
7dfd37b to
e7c83dc
Compare
pmolodo
force-pushed
the
pr/hdEmbree-tf-debug-create-light
branch
from
d33251e to
3ac23aa
Compare
pmolodo
force-pushed
the
pr/hdEmbree-inputs-diffuse
branch
from
e7c83dc to
896ab52
Compare
pmolodo
force-pushed
the
pr/hdEmbree-tf-debug-create-light
branch
from
3ac23aa to
05ff0ad
Compare
pmolodo
changed the base branch from
pr/hdEmbree-tf-debug-create-light
to
pr/hdEmbree-double-sided-mesh
pmolodo
force-pushed
the
pr/hdEmbree-inputs-diffuse
branch
from
896ab52 to
13bf404
Compare
pmolodo
force-pushed
the
pr/hdEmbree-double-sided-mesh
branch
from
65f44f3 to
2559f99
Compare
pmolodo
force-pushed
the
pr/hdEmbree-inputs-diffuse
branch
from
13bf404 to
988665c
Compare
pmolodo
force-pushed
the
pr/hdEmbree-double-sided-mesh
branch
from
2559f99 to
035a0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
hdEmbree multiples the
inputs:diffuseattribute into it's lighting calculation, since currently it assumes a material that is 100% diffuse.NOTE: This chain of PRs was made separate from the PR documenting expected behavior: