Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdEmbree] add direct camera visibility support for rect lights #7

Open
wants to merge 1 commit into
base: pr/hdEmbree-dome-lights
Choose a base branch
from

Conversation

pmolodo
Copy link

@pmolodo pmolodo commented Jul 31, 2024

Description of Change(s)

Makes rect lights potentially visible to direct camera rays. To enable, set inputs:visiblity:camera to True / 1.


NOTE: This chain of PRs was made separate from the PR documenting expected behavior:


  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@pmolodo pmolodo force-pushed the pr/hdEmbree-rect-light-direct-visibility branch from 0cbce3f to ff7aecd Compare August 1, 2024 18:46
@pmolodo pmolodo force-pushed the pr/hdEmbree-rect-light-direct-visibility branch from ff7aecd to 3b89f26 Compare September 23, 2024 18:11
@pmolodo pmolodo force-pushed the pr/hdEmbree-dome-lights branch from 55ae4aa to 14f2187 Compare September 23, 2024 18:11
@pmolodo pmolodo force-pushed the pr/hdEmbree-rect-light-direct-visibility branch from 3b89f26 to c947427 Compare October 21, 2024 17:06
@pmolodo pmolodo force-pushed the pr/hdEmbree-dome-lights branch from 14f2187 to b62a1f0 Compare October 21, 2024 17:06
@pmolodo pmolodo force-pushed the pr/hdEmbree-rect-light-direct-visibility branch from c947427 to ee0f175 Compare October 22, 2024 18:11
@pmolodo pmolodo force-pushed the pr/hdEmbree-dome-lights branch from b62a1f0 to e55982e Compare October 22, 2024 18:11
@pmolodo pmolodo force-pushed the pr/hdEmbree-rect-light-direct-visibility branch from ee0f175 to 4ea14e8 Compare October 23, 2024 17:29
@pmolodo pmolodo force-pushed the pr/hdEmbree-dome-lights branch from e55982e to 3a5cb18 Compare October 23, 2024 17:29
@pmolodo pmolodo force-pushed the pr/hdEmbree-rect-light-direct-visibility branch from 4ea14e8 to bfd9507 Compare October 23, 2024 18:20
@pmolodo pmolodo force-pushed the pr/hdEmbree-dome-lights branch from 3a5cb18 to 4cb4d2f Compare October 23, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant