Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check duplicate native surfaces #155

Merged
merged 2 commits into from
Nov 18, 2024

Commits on Nov 14, 2024

  1. Fix a segfault in wlEglCreatePlatformWindowSurfaceHook

    In the error cleanup path in wlEglCreatePlatformWindowSurfaceHook, don't
    try to dereference the WlEglSurface if we never allocated it.
    kbrenneman committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7d1d1aa View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Check for a duplicate wl_surface in wlEglCreatePlatformWindowSurfaceHook

    In wlEglCreatePlatformWindowSurfaceHook, check if there's already a
    EGLSurface that uses the same wl_surface object, and if so, fail with
    EGL_BAD_ALLOC.
    
    We've got a check (using the wl_egl_window::driver_private pointer) to
    catch if the app tries to create multiple EGLSurfaces from the same
    wl_egl_window. But, an app could still call wl_egl_window_create
    multiple times, which would give it multiple wl_egl_window structs for
    the same wl_surface.
    kbrenneman committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    83ea2aa View commit details
    Browse the repository at this point in the history