meta data name support #235
Open
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivakunv
force-pushed
the
ci-dynamicname
branch
8 times, most recently
from
c4e124c to
3d43889
Compare
shivakunv
commented
Dec 13, 2024
shivakunv
commented
Dec 13, 2024
shivakunv
commented
Dec 13, 2024
shivakunv
commented
Dec 13, 2024
shivakunv
commented
Dec 13, 2024
shivakunv
commented
Dec 13, 2024
shivakunv
commented
Dec 13, 2024
shivakunv
force-pushed
the
ci-dynamicname
branch
2 times, most recently
from
7a83c02 to
974bb03
Compare
Signed-off-by: shiva kumar <[email protected]>
shivakunv
force-pushed
the
ci-dynamicname
branch
from
974bb03 to
890030c
Compare
shivakunv
commented
Dec 15, 2024
| # Calico CRDs created. Now we sleep for 10s to ensure they are fully registered in the K8s etcd | ||
| sleep 10s | ||
| with_retry 3 10s kubectl --kubeconfig $KUBECONFIG apply -f https://raw.githubusercontent.com/projectcalico/calico/${CALICO_VERSION}/manifests/custom-resources.yaml | ||
| with_retry 3 10s kubectl --kubeconfig $KUBECONFIG create -f https://raw.githubusercontent.com/projectcalico/calico/${CALICO_VERSION}/manifests/custom-resources.yaml |
There was a problem hiding this comment.
with new calico version apply gives error
The CustomResourceDefinition "installations.operator.tigera.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes
shivakunv
requested review from
ArangoGutierrez,
elezar,
tariq1890 and
cdesiniotis
as code owners
shivakunv
commented
Dec 15, 2024
| parts := strings.Split(repo_name, "/") | ||
| repoName := parts[len(parts)-1] | ||
|
|
||
| cfg.Name = fmt.Sprintf("ci%s-%s-%s-%s-%s-%s", attempt, actor, branchName, repoName, sha, uid) |
There was a problem hiding this comment.
resultant gpu-driver-container e2e instance name with this change :
Actor: shivakunv
gpu-driver-container Branch Name: holodeckname
repo: gpu-driver-container
ci5-shivakunv-holodeckname-gpu-driver-container-a0917fc6-fqpz5zu8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.