Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the new logo everywhere on the website #118 #211

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MehtabAsHellic
Copy link

@MehtabAsHellic MehtabAsHellic commented May 31, 2024

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state "None”]

Description

Update the new logo everywhere on the website #118

Type of PR

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nacto-care ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 4:04pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @MehtabAsHellic! 🎉 Thank you for submitting your pull request. Your contribution is valuable, and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Harshil-Jani
Copy link
Member

@MehtabAsHellic Logo doesn't seem to work on deployment
image

@MehtabAsHellic
Copy link
Author

MehtabAsHellic commented Jun 3, 2024

@MehtabAsHellic Logo doesn't seem to work on deployment image

I will check again @Harshil-Jani and do the pr again

@MehtabAsHellic
Copy link
Author

Screenshot 2024-06-03 103957

When I am running the project npm run dev its showing

@Harshil-Jani
Copy link
Member

Harshil-Jani commented Jun 3, 2024

Prolly something with file paths when on deployment. Can you try it without using /public and keep it as it was ? Or maybe check paths of how other images are working.

@MehtabAsHellic
Copy link
Author

Prolly something with file paths when on deployment. Can you try it without using /public and keep it as it was ? Or maybe check paths of how other images are working.

ok

@MehtabAsHellic
Copy link
Author

@Harshil-Jani please check now

@anudeeps0306
Copy link
Collaborator

@MehtabAsHellic can you resolve the conflit

src/components/Header/Header.jsx Outdated Show resolved Hide resolved
@MehtabAsHellic
Copy link
Author

MehtabAsHellic commented Jun 6, 2024

I did change in the header path please check @Harshil-Jani
I am really sorry for the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants