Cleaning up some submap archetype code #4611
Open
+52
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out-of-phaze
previously requested changes
Dec 6, 2024
MistakeNot4892
force-pushed
the
tweak/submaps
branch
from
ccbf123 to
e635635
Compare
out-of-phaze
reviewed
Dec 9, 2024
| else | ||
| if(!global.submaps_by_name) | ||
| global.submaps_by_name = list() | ||
| for(var/decl/submap_archetype/submap as anything in decls_repository.get_decls_of_type_unassociated(/decl/submap_archetype)) |
There was a problem hiding this comment.
i wonder if this is actually necessary? we're already looping over all submap archetypes in the validation test, so theoretically it could just be
if(global.submaps_by_name[name])
. += "name '[name]' conflicts with submap type '[global.submaps_by_name[name]]'"
else
global.submaps_by_name[name] = typeand obviously submaps_by_name would have to always be a list for this code to work exactly as i wrote it
that said i think it should be a static var to avoid someone trying to access it outside of validation
There was a problem hiding this comment.
Yeah good call, makes it much simpler.
…map availability.
MistakeNot4892
force-pushed
the
tweak/submaps
branch
from
e635635 to
9c068f7
Compare
out-of-phaze
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
descriptoris nownameso that they'll behave nicely in input() in the future.Why and what will this PR improve
No crashed pods on Shaded Hills.
Authorship
Myself.
Changelog
Nothing player-facing.