Various clothing and equipment tweaks for Karzerfeste. #4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MistakeNot4892
commented
Dec 7, 2024
MistakeNot4892
commented
- Outfits can be given lists of types instead of single types.
- Added sleeved robes.
- Added various clothing and tool subtypes for fantasy.
MistakeNot4892
force-pushed
the
map/shaded_hills
branch
from
f3478c6 to
8439b73
Compare
out-of-phaze
previously approved these changes
Dec 9, 2024
code/datums/outfits/outfit.dm
Outdated
|
|
||
| // Ears, backpack and uniforms are handled individually. | ||
| var/list/slot_to_gear = list( | ||
| slot_wear_suit_str = resolve_equip_to_list(suit), |
There was a problem hiding this comment.
this is a define, so it might actually work, but i'm a little worried about using bare list keys like this. actually no i know for a fact it'll work until someone makes a typo or include order error when adding a new one, and then it'll insert the nonexistent variable as a string. so... dunno. fine as is i guess but wrapping it in parens is technically safer
There was a problem hiding this comment.
I can do that for clarity easily enough.
MistakeNot4892
force-pushed
the
map/shaded_hills
branch
from
8439b73 to
ef86cd4
Compare
out-of-phaze
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.