Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocating/cleaning up some bodytype logic. #4641

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Relocating/cleaning up some bodytype logic. #4641

wants to merge 2 commits into from

Conversation

MistakeNot4892
Copy link
Contributor

  • Moves bodytype stuff into a modules folder.
  • Removes an unused eye offset and the obviated icon_uid (uses decl uid instead).
  • Comments/formats the main bodytype file.
  • Privates the bodytype organ category and tag lists.
  • Moves surgery overlay icons onto bodytype.
  • Probably some other stuff I missed.

@MistakeNot4892 MistakeNot4892 added the ready for review This PR is ready for review and merge. label Dec 13, 2024
@out-of-phaze
Copy link
Member

would like the eye offsets back, i use them for replikas on a downstream

@MistakeNot4892
Copy link
Contributor Author

would like the eye offsets back, i use them for replikas on a downstream

Restored, added a comment so I don't do it again sometime.

MistakeNot4892
MistakeNot4892 commented Dec 15, 2024
View reviewed changes
code/modules/bodytype/_bodytype.dm

for(var/organ_tag in has_organ)
var/obj/item/organ/organ = has_organ[organ_tag]
var/organ_cat = initial(organ.organ_category)
if(organ_cat)
LAZYADD(organs_by_category[organ_cat], organ)
LAZYADD(organ_tags_by_category[organ_cat], organ_tag)
LAZYINITLIST(_organs_by_category)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just realised these weren't lazylisted because they're on bodytypes which are singletons. I'm not bright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MistakeNot4892 @out-of-phaze