Allow an account specific allow list for some categories #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpalriwal-Netflix
force-pushed
the
main
branch
from
25af790
to
83d5756
Compare
| @@ -542,6 +542,7 @@ atlas { | |||
| "dynamodb-table-ops", | |||
| "dynamodb-capacity", | |||
| "dynamodb-replication", | |||
| "ec2-asg", | |||
There was a problem hiding this comment.
Can you keep this list sorted? It makes it easier to sanity check later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow to restrict some high cardinality or specific custom namespace metric for only a defined allowed list of account, unlike all other namespace is allowed for all as default.
ec2-Asg config will only allow ASG dimension, which is low cardinality and should be fine for all accounts.