Remove incorrect toString() for URL in RestClientGraphQLClient error handling #2069
+24
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2059.
By default, the error handling for failing HTTP requests is done by
RestClient
itself, so the extra error check we have in code is typically not used. Added a test for this.If a non-default status code handler is configured on the
RestClient
, it might still fall through, so I kept the existing error handling. However, I removed the incorrecttoString()
use for theurl
field in the exception.In a
RestClient
you can't actually see what URL it is configured for, so we don't have access to the URL during error handling in this case. This is acceptable because this exception only throws when the user overrides the handling, and not handle a status code correctly.