Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertoor #6935

Merged
merged 47 commits into from
Aug 22, 2024
Merged

Assertoor #6935

merged 47 commits into from
Aug 22, 2024

Conversation

kamilchodola
Copy link
Contributor

@kamilchodola kamilchodola commented Apr 19, 2024

Added a new testing tool from EF called "Assertoor" https://github.com/ethpandaops/assertoor and also connected it with a tests collection from https://github.com/ethpandaops/assertoor-test using a dynamic script which will automatically add new tests whenever such ones appear.

Currently filtered out a few recommended by EF DevOps folks.

In future it is a matter of being parallelized and subset of tests to be run on each commit (for example block production verification).

NOTE:
Currently using a fork of assertor-test https://github.com/kamilchodola/assertoor-test) because waiting for ethpandaops/assertoor-test#10 to be merged - but there are some doubts about some edge cases so until then will keep it like this.

Changes

  • List the changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@kamilchodola kamilchodola marked this pull request as ready for review August 14, 2024 13:52
@kamilchodola kamilchodola requested review from rubo and a team as code owners August 14, 2024 13:52
@kamilchodola kamilchodola requested a review from a team August 14, 2024 13:53
@kamilchodola kamilchodola merged commit 871b025 into master Aug 22, 2024
62 of 66 checks passed
@kamilchodola kamilchodola deleted the kch/assertoor branch August 22, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants