GUI: Add a fast-select "Zapper" mode for VarItemList #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxkmm
requested review from
Willy-JL,
Sil333033,
HaxSam and
MatthewKuKanich
as code owners
zxkmm
commented
Oct 12, 2024
| false); | ||
|
|
||
| if(consumed) return true; |
There was a problem hiding this comment.
it's for prevent the zapper menu infect in the var_item meny obj.
| @@ -285,6 +460,15 @@ static bool variable_item_list_input_callback(InputEvent* event, void* context) | |||
| default: | |||
| break; | |||
| } | |||
| } else if(event->type == InputTypeLong) { | |||
There was a problem hiding this comment.
only one option but switch to keep it clean
| { | ||
| VariableItem* item = variable_item_list_get_selected_item(model); | ||
|
|
||
| bool is_allowed = false; |
There was a problem hiding this comment.
this is just for prevent mistaken-touch for those two options field. but they works good too, just i think not needed
|
|
Willy-JL
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Add a fast-select "Zapper" function for var_item type menu
it's 4 times faster when you are looking for a item (e.g. a frequency)
I't s extremely fast (and don't even need to look at the screen) if you remember the number (position) of that specific item (for example the most used two: 315 and 433.92)
TODOCurrent interface is kinda ugly. Need to design a new one maybe.For the reviewer