Had some additional contributes #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made changes so that script recreates only certain tables. made fixes to the create table scripts and added a delete existing table if it exists. added type 106/108 adjustment so that they are saved as decimals. fixed mysql connection timeout issues added conversion for datetime.datetime types in python for mysql as well as changing NONE to 0 added close connection for mysql and sql i think that is everything…didnt think i would be submitting to github when i started. correct me if I did anything completely bass ackward
import files instead of opening, reading, executing. it's safer and preferred adjust variables to use new imports create mysql connection and cursor outside of for-loop. better for performance
Moes changes
moved the where name in back to the constructed variable and change the else ms_tables to return empty…
a couple of coding errors fixed, made a change to the if/else statement so that it can pull back all the tables or views if none are defined. functions : check_table_exists was closing the cursor so removed those lines added commas to sqlserver_datatypes that were missing
table names: you can now specify table names and what you want the new table to be named coltype: fixed it so that certain columns ( 60, 104, 106, 108) are cast as varchar to get around the problem that some of these fields where longer than what was in the database. I don’t know if this is the smartest way around it but it worked.
i must have hit undo at some point…fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to merge some changes from an additional contributor?