Make the subproject dir src again
#11669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
requested review from
fricklerhandwerk and
edolstra
as code owners
github-actions
bot
added
documentation
new-cli
This is needed to avoid this mesonbuild/meson#13774 when we go back to making our subproject directory `src`.
We got rid of this in c7ec336 because of bug mesonbuild/meson#13774, but in the previous commit we renamed the manual source directory, which avoids it. Now we can change it back.
Ericson2314
force-pushed
the
doc-source-rename
branch
from
aea217f to
379ada4
Compare
edolstra
approved these changes
Oct 16, 2024
|
I think this broke the "Suggest an edit" button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to avoid a mess of symlinks for Meson that make things confusing. We current have a
/subprojects -> srcsymlink that would be good to get rid of.Context
We got rid of this in c7ec336 because of bug mesonbuild/meson#13774, but in the first commit of this renamed the manual source directory, which avoids it. Now we can change it back.
#2503
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.