Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unit tests to the location Meson expects them to be #11708

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Ericson2314
Copy link
Member

Motivation

Everything that is a separate subproject should live in the subprojects directory.

Context

Progress on #2503

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added documentation contributor-experience Developer experience for Nix contributors with-tests Issues related to testing. PRs with tests have some priority labels Oct 16, 2024
@Ericson2314 Ericson2314 changed the title Move tests to the location Meson expects Move functional tests to subproject dir Oct 16, 2024
@Ericson2314 Ericson2314 changed the title Move functional tests to subproject dir Move unit tests to the location Meson expects them to be Oct 16, 2024
@edolstra
Copy link
Member

edolstra commented Oct 17, 2024

For consistency, maybe it should be libexpr-tests instead of nix-expr-tests (etc.)? That would make it easier to see that each lib* directory has a corresponding test directory.

@Ericson2314
Copy link
Member Author

OK, did that.

@Ericson2314 Ericson2314 enabled auto-merge October 17, 2024 19:34
Everything that is a separate subproject should live in the subprojects
directory.

Progress on NixOS#2503

This reverts commit 451f8a8.
@Ericson2314 Ericson2314 merged commit 694c378 into NixOS:master Oct 17, 2024
11 checks passed
@Ericson2314 Ericson2314 deleted the move-tests branch October 17, 2024 20:32
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-10-16-nix-team-meeting-minutes-187/54835/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor-experience Developer experience for Nix contributors documentation with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants