Fix cross build (was: fix manual) #11820
Conversation
roberth
added
the
build-problem
|
@mergify rebase |
❌ Pull request can't be updated with latest base branch changesMergify needs the author permission to update the base branch of the pull request. |
|
This doesn't exactly make our Nix expressions easier to understand (and they're already massively more complex than a couple of releases ago). For instance, I have no idea what "splices" are (the Nixpkgs manual is unhelpful in this respect), so the use of functions like |
flake.nix
Outdated
| inherit inputs stdenv; | ||
| pkgs = final; | ||
| }); | ||
| nixDependencies = lib.makeScopeWithSplicing' |
There was a problem hiding this comment.
So the meta-critique here is that these functions are not documented?
So let's just do that in nixpkgs?
There was a problem hiding this comment.
flake.nix
Outdated
| inherit (final) newScope; | ||
| } | ||
| { | ||
| otherSplices = final.generateSplicesForMkScope "nixDependencies"; |
|
I agree. NixOS/nixpkgs#354198 is definitely a problem. |
|
@roberth it would be great if I could use mergify for rebasing your pull requests, but that's not possible for the hercules-ci nix fork. Would you mind in future to just push directly to the nix repository? This avoids some back and forth. Maybe there is also a different way to have write access to repositories originating from orgs. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-11-06-nix-team-meeting-minutes-192/55847/1 |
roberth
force-pushed
the
fix-cross-manual
branch
from
b3377d2 to
b28865a
Compare
We *could* use a "native" manual instead - ie reusing a native
`nixpkgsFor.${buildPlatform}`, but this works, and also
works for possible cases where we have a custom or patched build tool.
roberth
force-pushed
the
fix-cross-manual
branch
from
b28865a to
747cf4e
Compare
|
I would like go merge this. We shouldn't be blocked by Nixpkgs doc issues. |
|
@edolstra Something like this is required to fix the cross build of IMO the readability is a problem that should be fixed in Nixpkgs, and Nix should just follow its lead. |
|
Thanks! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-12-02-nix-team-meeting-minutes-199/56961/1 |
Motivation
Fix the build!
I don't think we had a manual in the cross build in the past, so this is nice.
Tested with:
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.