Refactor flake.nix to remove flake-utils #177
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,31 @@ | ||
| { | ||
| outputs = | ||
| { self, nixpkgs }: | ||
| let | ||
| forAllSystems = nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed; | ||
|
|
||
| result = forAllSystems (system: import ./default.nix { inherit system; }); | ||
| in | ||
| { | ||
| packages = forAllSystems ( | ||
| system: | ||
| let | ||
| packages = result.${system}.packages; | ||
| in | ||
| packages // { default = packages.nixfmt; } | ||
| ); | ||
|
|
||
| apps = forAllSystems (system: { | ||
| default = { | ||
| type = "app"; | ||
| program = nixpkgs.lib.getExe self.packages.${system}.default; | ||
| }; | ||
| }); | ||
|
|
||
| checks = forAllSystems (system: result.${system}.checks); | ||
|
|
||
| devShells = forAllSystems (system: { | ||
| default = result.${system}.shell; | ||
| }); | ||
|
Comment on lines
+27
to
+29
There was a problem hiding this comment. What's the motivation for this? There was a problem hiding this comment. Using There was a problem hiding this comment. Makes sense, sounds fine to have this :) Personally I'm using https://github.com/nix-community/nix-direnv, which also caches the shell for speed There was a problem hiding this comment. If the flake-utils part is staying, I could just put in this commit & axe the other. |
||
| }; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed
flake-utils, but addednixpkgs(and that without aninputsentry, which then runs into NixOS/nix#7422). And if you don't commit the lockfile as here, we'll run into further non-reproducibility. Alternatively if you do commit the lockfile, we'll have two Nixpkgs versions that need to be fetched for the flake.So, I don't think we should do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the current version using the
builtinsdependencies offlake-utilsbeing more reproducible than using the lib from Nixpkgs? Seems most folks are used to passing ininputs.nixpkgs.followsthru their flakes. I suppose you could get lib from npins, but really after thinking about it, might it just be simpler to manually write outx86_64-linux, et al. forsystem.exposedFlakesand remove all dependencies then? It’s more repetitious “code”, but has zero dependencies. I would be willing to write it out.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, 32-bit Linux is one of the supported systems in Hydra but is missing from
flake-utils’sdefaultSystems.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just because in the current PR at least, Nixpkgs isn't pinned, while flake-utils is. Without committing the lockfile to pin it, people will get different results at different points in time.
That doesn't actually work, the npins-pinned Nixpkgs can't be overridden like that (see #166 for what works instead)
Actually one thing that
flake-utilsallows you is to use the https://github.com/nix-systems/nix-systems pattern, which allows consumers to work around the problem of Flakes requiring a hardcoded list of systems. This wouldn't be possible anymore if we hardcode the systems locally.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Fair assessments as I misunderstand the environment. Thank you for explaining as I don’t see many places with a
flake.nix& not using Nix to pin their Nixpkgs as well (which is why it feels like Nixpkgs is always a given).