sasquatch: 4.3 -> 4.4

[cole-h]

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 119996 at ccd4be6e run on aarch64-linux 1

5 packages built successfully:

• python38Packages.binwalk
• python38Packages.binwalk-full
• python39Packages.binwalk
• python39Packages.binwalk-full
• sasquatch

---

Result of nixpkgs-review pr 119996 at ccd4be6e run on x86_64-linux 1

5 packages built successfully:

• python38Packages.binwalk
• python38Packages.binwalk-full
• python39Packages.binwalk
• python39Packages.binwalk-full
• sasquatch

1 suggestion:

• warning: missing-patch-comment

  Please add a comment on the line above, explaining the purpose of this patch.
  Near pkgs/tools/filesystems/sasquatch/default.nix:44:15:

     |
  44 |   patches = [ patch ];
     |               ^
  

[Pamplemousse]

Hey @SuperSandro2000,

Question about the lz4 ? null becoming lz4 (and the related assert... removal):

• Why? What's the point of including lz4 if lz4Support is False?
• Was that superfluous before? Why?

Thanks 🙂

[cole-h]

lz4 ? null is unnecessary because, if it's unused, it won't be included in the output / closure. Nix is lazy, so any unused variables (packages) won't be evaluated / built / etc.

[cole-h]

@Pamplemousse Do you perchance have any test cases for this? I want to make sure that I didn't break unsquashing LZMA / etc when I went the easy route of just incrementing the #defines (devttys0/sasquatch#33 (comment)).

[Pamplemousse]

@cole-h Unfortunately no. I haven't used this since I packaged it, and it was a "one-off" need...

[grahamc]

For posterity sake I also replicated it here: https://github.com/DeterminateSystems/sasquatch