musl: 1.2.3 -> 1.2.5

[alyssais]

From a packaging perspective, this is the most important thing about this upgrade:

Users who build applications from source against musl should be aware: 1.2.4 deprecates the "LFS64" interfaces, which were provided via macros (causing lots of frustration by breaking things; thus the motivation to get rid of them).

Builds which break can be fixed for now by adding -D_LARGEFILE64_SOURCE to CFLAGS, but this too will be dropped in a later version.

Source

I think we should see which packages are affected, and give it some reasonable amount of time for them to be fixed, because I don't think it's going to always be as simple as modifying CFLAGS — what do we do for rustc, for example?

We also have some work ahead of us to even identify broken packages. I've done some test builds of the Spectrum live image, which heavily uses musl, to identify a few regressions, but since we don't have Hydra for musl, we're going to need people who use musl in Nixpkgs to do their own test builds to check whether any of the packages they care about are affected. If you do so, add any more broken packages to the list in this post (or comment if you lack permissions).

• LLVM llvm: backport patch for musl 1.2.4 #229442
• libselinux libselinux: remove use of LFS64 function #287471
• acl acl: backport patch for musl 1.2.4 #229440
• xorg.libpciaccess xorg.libpciaccess: backport patch for musl 1.2.4 #229441
• rustc (and cross-compiled programs that use non-musl build rustc) rustc: 1.72.1 -> 1.73.0 #259989
• gperftools gperftools: 2.10 -> 2.15 #253556
• gdb gdb: backport patch for musl 1.2.4 #229673
• doxygen doxygen: unvendor spdlog #292630
• libredirect libredirect: don't test LFS64 functions on musl #292616
• numactl numactl: 2.0.16 -> 2.0.17 #281724
• autogen autogen: patch out use of LFS64 functions #292617
• libeatmydata Fix sync_file_range() with musl 1.2.4 stewartsmith/libeatmydata#36 libeatmydata: patch out LFS64 usage #324772
• bpftools
• libbpf
• gst_all_1.gstreamer
• meson meson: 1.3.2 -> 1.4.0 #298047
• elfutils elfutils: 0.190 -> 0.191 #293517
• yara yara: backport LFS64 removal #306531
• directfb directfb: use POSIX basename() #309583
• systemd linuxHeaders: 6.7 -> 6.9 #311995
• gpgme (Alpine patch) (Proposed upstream patch) gpgme: patch out LFS64 usage #324771
• mblaze mblaze: backport LFS64 removal #306517
• f2fs-tools f2fs-tools: backport LFS64 removal #306514
• ocamlPackages.uring ocamlPackages.uring: add patch for musl 1.2.5 #307693
• wgautomesh wgautomesh: 0.1.0 -> unstable-20240524 #321524
• libfaketime libfaketime: backport LFS64 fix for musl 1.2.4 #313663
• aemu https://android-review.googlesource.com/c/platform/hardware/google/aemu/+/3105640/1, https://cyberchaos.dev/yuka/nixpkgs/-/commit/5e94b5a82ecbfcefd60c5f8f21d98ba7361eeac2 aemu: pick fix for musl >1.2.4 #330609
• e2fsprogs (Alpine patch) (Upstream patch) e2fsprogs: 1.47.0 -> 1.47.1 #313657
• fuse2 (issue in fuse headers manifests in e2fsprogs after updating) (Void patch) no other package seems to have that problem, and e2fsprogs is fixed now.
• mdadm (Alpine patch) (Proposed upstream patch) mdadm: fix build with musl 1.2.5 #313936
• xfsprogs https://termbin.com/8vdm xfsprogs: 6.6.0 -> 6.8.0 #304745
• multipath-tools multipath-tools: 0.9.6 -> 0.9.8; backport build fix for musl libc 1.2.5  #313682
• kmod kmod: backport patch for musl 1.2.5 #322720
• mumble mumble: unpin protobuf #322756
• anything that uses protobuf 21, (wontfix, mark as broken: https://cyberchaos.dev/yuka/nixpkgs/-/commit/37d0ec2c0a91314de3177ab1a9ce838693b020a0) treewide: unpin protobuf_21 where possible #339631
• nfs-utils (nfs-utils: enable ldap support, and update to 2.6.4 #278160, https://cyberchaos.dev/yuka/nixpkgs/-/commit/c53c94dbe882936eeb2956d6f5655540cc1debe4)
• openjdk17 (openjdk17: backport musl 1.2.4 fixes #327135, https://cyberchaos.dev/yuka/nixpkgs/-/commit/0f58ffa8cf636cece3079b68eebf2c5082a50f01)
• gn gn: backport LFS64 cleanup #339794
• intel-gpu-tools intel-gpu-tools: backport fix for musl 1.2.5 #341576
• catfs catfs: 0.9.0 -> 0.9.0-unstable-2023-10-09 #325088

New! with GCC 14

• attr attr: backport patch for musl 1.2.5 #342008
• bluez bluez: add patch for musl 1.2.5 #342281
• elogind elogind: 246.10 -> 255.5 #342236
• kexec-tools kexec-tools: 2.0.28 -> 2.0.29 #342004
• libapparmor libapparmor: backport patch for musl 1.2.5 #342013
• util-linux util-linux: backport patch for musl 1.2.5 #342019
• iproute2 iproute2: fix building for musl with GCC 14 #342002

Where we can fix things without breaking things for musl 1.2.3, let's apply those fixes in separate PRs, so the work can be more easily spread out, and avoid this one becoming intimidatingly huge.

Resources

• Alpine Linux's fixes

[alyssais]

#259989 includes the necessary Rust fixes, so will unblock this when merged.

[alyssais]

1.2.5 is out now, but it doesn't look like anything in that update will be nearly as hard as LFS in 1.2.4, so I'm now aiming to go straight to 1.2.5 with this. Help with reviewing the package fixes (the libselinux one has been open for a while) would be very helpful with getting this moving.

[alyssais]

@yu-re-ka can we keep them all in the big list in the PR body? Otherwise they're going to get hard to keep track of when GitHub starts hiding comments.

[AndersonTorres]

There is a PR updating GN here:

#221306

[yu-re-ka]

The gn update does not address the LFS64 breakage though

[alyssais]

Unless there are any last minute objections, I intend to merge this with the next staging cycle. (There aren't enough rebuilds to force this into staging, but there are important fixes that are only in staging.) Every package previously identified as regressing on update builds with musl 1.2.5 on staging, with the exception of nfs-utils, which doesn't work on master anyway and hasn't for a while. Merging this is the best way to fix building pulseaudio with musl and GCC 14, and we're also increasingly seeing packages relying on features introduced in later versions of musl — there are two reverts for hacks we've had to do for 1.2.3 in this PR, and I also recently discovered that we need a newer musl for bcachefs-tools.

Since we don't have Hydra for musl, there will absolutely be a long tail of broken packages that we can't identify, but it's been a year and a half. This is as good as it's going to get, and we can't hold back forever.

[SuperSandro2000]

go for it 🎉