-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmuxifier: init at 0.13.0 #254328
tmuxifier: init at 0.13.0 #254328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta.maintainers
is missing
Please change the commit message to the PR title. |
I think it is optional. Could you provide some pointers to the mandatory requriement? |
It should be set: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#meta-attributes |
Thank you all for this. ❤️ |
@dotlambda all your suggestions are applied. Please, let me know if something is missing. |
@jian-lin @dotlambda just a friendly ping. Could you mark your requested changes as resolved, please? (all your requested changes are applied) |
I don't feel comfortable merging this because of the non-standard install phase. Someone should test if this actually works. |
I use this package heavily in a container (builded with dockerTools.buildLayeredImage). Also, I tested that ./result/bin/tmuxifier (create session and window, starting session) works as expected. |
I don't fill that this patch will ever be merged, because there are 4 peoples in the review and I don't see if anybody would like to test it. @dotlambda Is it possible to rewrite or drop things you don't like in install phase, so it could be finally merged? It's kinda strange for me that the proposed thing is now blocking from the merge. If we choose rewriting, how the install phase should look like? Do we need *.patch files instead of 'sed' command invocation? |
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)This pull request will add requested in #226393 package. The Nix package tested on my machine and in a container builded with dockerTools.buildLayeredImage function.
fixes #226393
cc @adam248