Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lbzip2: apply implicit function definition patch; fix darwin #277638

Merged
merged 1 commit into from Jan 1, 2024
Merged

lbzip2: apply implicit function definition patch; fix darwin #277638

merged 1 commit into from Jan 1, 2024

Conversation

ghost
Copy link

@ghost ghost commented Dec 30, 2023

apply patch kjn/lbzip2#33 to fix darwin build

https://hydra.nixos.org/build/244010095

Result of nixpkgs-review pr 277638 run on x86_64-linux 1

19 packages built:
  • lbzip2
  • python310Packages.condaInstallHook
  • python310Packages.torchWithRocm
  • python310Packages.torchWithRocm.cxxdev
  • python310Packages.torchWithRocm.dev
  • python310Packages.torchWithRocm.dist
  • python310Packages.torchWithRocm.lib
  • python311Packages.condaInstallHook
  • python311Packages.torchWithRocm
  • python311Packages.torchWithRocm.cxxdev
  • python311Packages.torchWithRocm.dev
  • python311Packages.torchWithRocm.dist
  • python311Packages.torchWithRocm.lib
  • rocmPackages.migraphx
  • rocmPackages.miopen (rocmPackages.miopen-hip)
  • rocmPackages.miopen-opencl
  • rocmPackages.mivisionx (rocmPackages.mivisionx-hip)
  • rocmPackages.mivisionx-cpu
  • rocmPackages.mivisionx-opencl

Result of nixpkgs-review pr 277638 run on x86_64-darwin 1

3 packages built:
  • lbzip2
  • python310Packages.condaInstallHook
  • python311Packages.condaInstallHook

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 30, 2023
@ofborg ofborg bot requested a review from abbradar December 30, 2023 02:19
@7c6f434c 7c6f434c merged commit 27d55df into NixOS:master Jan 1, 2024
29 checks passed
Copy link
Contributor

github-actions bot commented Jan 1, 2024

Successfully created backport PR for release-23.11:

@ghost
Copy link
Author

ghost commented Jan 1, 2024

thanks!

@ghost ghost deleted the lbzip2-fix branch January 1, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant