Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-licenses: fix returning empty output when GOROOT differs from built environment #279620

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

SuperSandro2000
Copy link
Member

Description of changes

Noticed this while reviewing licenses in go projects at work. With the wrapper the necessary variable is set on demand to make the tool work.

see google/go-licenses#149

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@Luflosi Luflosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small nit-pick, this LGTM.
It's unfortunate that we have to pull in the entire Go package, just to get the path to GOROOT. But I don't know how else to do it since the upstream package seems to be written this way, so let's do it this way.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 11, 2024
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 11, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 11, 2024
@ofborg ofborg bot requested a review from Luflosi January 11, 2024 15:15
@NickCao NickCao merged commit 1e48199 into NixOS:master Jan 14, 2024
23 checks passed
@SuperSandro2000 SuperSandro2000 deleted the go-licenses-fix branch January 14, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants