Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ltris: 1.2.7 -> 1.2.8 #291413

Merged
merged 3 commits into from
Mar 1, 2024
Merged

ltris: 1.2.7 -> 1.2.8 #291413

merged 3 commits into from
Mar 1, 2024

Conversation

AndersonTorres
Copy link
Member

Description of changes

Closes #290091

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres
Copy link
Member Author

@drupol Now it is!

@AndersonTorres AndersonTorres marked this pull request as ready for review February 25, 2024 19:21
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 25, 2024
@wegank wegank mentioned this pull request Feb 28, 2024
Merged
13 tasks
@AndersonTorres
ltris: migrate to by-name
ad38311
@AndersonTorres
ltris: refactor
39ba389 
- finalAttrs design pattern
- get rid of nested with
- set meta.mainProgram
@AndersonTorres
ltris: 1.2.7 -> 1.2.8
79b7518
@AndersonTorres AndersonTorres requested a review from drupol March 1, 2024 01:12
@drupol drupol merged commit c6a6cda into NixOS:master Mar 1, 2024
25 checks passed
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndersonTorres @drupol @delroth