Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] php - many PR backports #293574

Merged
merged 15 commits into from
Mar 6, 2024

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Mar 5, 2024

Backport of #285828, #292511, #292524, #288574

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol drupol marked this pull request as ready for review March 5, 2024 20:01
@drupol
Copy link
Contributor Author

drupol commented Mar 5, 2024

@ofborg build phpunit phpPackages.psalm snipe-it php81Packages.php-cs-fixer

@drupol drupol changed the title [backport] build-support/php: set COMPOSER_ROOT_VERSION environment variable [backport] php - many PR backports Mar 5, 2024
@LeSuisse
Copy link
Contributor

LeSuisse commented Mar 5, 2024

cc70b31d4372ba19b1b9c15b5f7ffe5a68108b93, 734d70dcf5d0452972814316103e238481552635, e67b2228bf3ff22d7f7bfd359460878a56f63018 and 69adecb8798a29a8c1d59a95287109e75aae1df2 are probably not fine to backport. They are either major upgrades or breaking changes.

@drupol drupol force-pushed the php/backport/build-support/php branch from e9f4639 to 9da7260 Compare March 5, 2024 20:34
@drupol
Copy link
Contributor Author

drupol commented Mar 5, 2024

I removed the commits you mentioned, WDYT ?

@drupol drupol force-pushed the php/backport/build-support/php branch from 9da7260 to f666693 Compare March 5, 2024 20:59
drupol and others added 5 commits March 5, 2024 22:00
Re-generated the `composer.lock` with PHP 8.1 so it does not pick
up dependencies not compatible with it.

(cherry picked from commit 62bd6ea)
Re-generated the `composer.lock` with PHP 8.1 so it does not pick
up dependencies not compatible with it.

(cherry picked from commit 2e2b5b1)
@drupol drupol force-pushed the php/backport/build-support/php branch from f666693 to 5e9aea3 Compare March 5, 2024 21:00
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new failures.

Result of nixpkgs-review pr 293574 run on x86_64-linux 1

5 packages failed to build:
  • php81Packages.phpstan
  • php82Packages.phpstan
  • php83Packages.phpstan
  • phpdocumentor
  • robo
46 packages built:
  • adminer
  • bookstack
  • librenms
  • n98-magerun
  • n98-magerun2
  • pdepend
  • phel
  • php81Packages.box
  • php81Packages.castor
  • php81Packages.composer
  • php81Packages.grumphp
  • php81Packages.phan
  • php81Packages.phive
  • php81Packages.php-cs-fixer
  • php81Packages.php-parallel-lint
  • php81Packages.phpmd
  • php81Packages.psalm
  • php81Packages.psysh
  • php82Packages.box
  • php82Packages.castor
  • php82Packages.composer
  • php82Packages.grumphp
  • php82Packages.phan
  • php82Packages.phive
  • php82Packages.php-cs-fixer
  • php82Packages.php-parallel-lint
  • php82Packages.phpmd
  • php82Packages.psalm
  • php82Packages.psysh
  • php83Packages.box
  • php83Packages.castor
  • php83Packages.composer
  • php83Packages.grumphp
  • php83Packages.phan
  • php83Packages.phive
  • php83Packages.php-cs-fixer
  • php83Packages.php-parallel-lint
  • php83Packages.phpmd
  • php83Packages.psalm
  • php83Packages.psysh
  • phpactor
  • phpunit
  • pixelfed
  • platformsh
  • snipe-it
  • vimPlugins.phpactor

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 5, 2024
@ofborg ofborg bot requested a review from apeschar March 5, 2024 21:21
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Mar 5, 2024
@LeSuisse LeSuisse merged commit 19c255a into NixOS:release-23.11 Mar 6, 2024
24 of 25 checks passed
@drupol drupol deleted the php/backport/build-support/php branch March 6, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants