goxlr-utility: 1.1.1 -> 1.1.1-unstable-2024-08-06 #332757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
11.by: package-maintainer
|
Apparently goxlr-utility is also affected by #332957 so if I can figure out what that actually means maybe I should fix it at the same time. |
|
Seems like at least "time" package has been updated couple weeks ago so maybe just updating to latest master (there haven't been versioned releases since 1.1.1) would solve this. |
errnoh
force-pushed
the
goxlr-fix-launcher
branch
from
9432d4b
to
46daa9a
Compare
errnoh
changed the title
SuperSandro2000
requested changes
Aug 8, 2024
fixes NixOS#331319 where user expects xdg desktop entry to continue work as a launcher hopefully also helps with NixOS#332957
errnoh
force-pushed
the
goxlr-fix-launcher
branch
from
51bcd00
to
eb8268e
Compare
errnoh
changed the title
|
Thanks for the review @SuperSandro2000! Added the suggested changes and reverted the speechd dependency change as it's not really necessary. |
SuperSandro2000
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeAutostartItembut seems like somewhat sane method of getting the result we want.The module change should work fine without the
+fixversion of the package, but both are needed to solve the full user experience issue.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.