Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mchprs: 0.4.1 -> 0.5.1 #344670

Merged
merged 1 commit into from
Oct 7, 2024
Merged

mchprs: 0.4.1 -> 0.5.1 #344670

merged 1 commit into from
Oct 7, 2024

Conversation

ocfox
Copy link
Member

@ocfox ocfox commented Sep 26, 2024

Description of changes

part of #332957

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ocfox
Copy link
Member Author

ocfox commented Sep 26, 2024

@ofborg eval

@ocfox ocfox added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 29, 2024
@pbsds
Copy link
Member

pbsds commented Oct 6, 2024

this fixes the build on darwin

diff --git a/pkgs/games/mchprs/default.nix b/pkgs/games/mchprs/default.nix
index cc1641f1dd1b..88d09149c6de 100644
--- a/pkgs/games/mchprs/default.nix
+++ b/pkgs/games/mchprs/default.nix
@@ -44,6 +44,7 @@ rustPlatform.buildRustPackage rec {
     ++ lib.optionals stdenv.hostPlatform.isDarwin [
       darwin.apple_sdk.frameworks.CoreFoundation
       darwin.apple_sdk.frameworks.Security
+      darwin.apple_sdk.frameworks.SystemConfiguration
     ];

   meta = with lib; {

Co-authored-by: Peder Bergebakken Sundt <[email protected]>
@pbsds pbsds merged commit ab0bdd5 into NixOS:master Oct 7, 2024
26 checks passed
@ocfox ocfox deleted the mchprs branch October 7, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants