Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coqPackages.mathcomp-analysis: rename altreals to experimental-reals #353818

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Nov 5, 2024

Following math-comp/analysis#1378

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@proux01
Copy link
Contributor Author

proux01 commented Nov 6, 2024

@vbgl CI green both here and on coq-community/coq-nix-toolbox#283 (and Analysis master tested on math-comp/analysis#1378 )

@vbgl vbgl marked this pull request as ready for review November 6, 2024 08:55
@vbgl vbgl merged commit 1be419d into NixOS:master Nov 6, 2024
34 of 37 checks passed
@proux01
Copy link
Contributor Author

proux01 commented Nov 6, 2024

Thanks

@proux01 proux01 deleted the analysis-experimental-reals branch November 6, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants