Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: move to by-name #357828

Merged
merged 17 commits into from
Nov 22, 2024
Merged

treewide: move to by-name #357828

merged 17 commits into from
Nov 22, 2024

Conversation

liberodark
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor

GaetanLepage commented Nov 21, 2024

Migrations to by-name will be handled later and are part of the RFC 140 implementation schedule.
#211832

@liberodark liberodark deleted the by-name1 branch November 21, 2024 13:13
@liberodark liberodark restored the by-name1 branch November 21, 2024 13:14
@liberodark liberodark deleted the by-name1 branch November 21, 2024 13:14
@infinisil
Copy link
Member

@GaetanLepage We updated the guidelines, it's okay to move manually because it empowers people using the merge bot, see https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name#manual-migration-guidelines

@GaetanLepage
Copy link
Contributor

@GaetanLepage We updated the guidelines, it's okay to move manually because it empowers people using the merge bot, see https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name#manual-migration-guidelines

Oh right ! I was not up-to-date regarding the guidelines indeed. Thanks for the heads-up :)

@liberodark liberodark restored the by-name1 branch November 21, 2024 23:08
@GaetanLepage GaetanLepage reopened this Nov 21, 2024
@GaetanLepage GaetanLepage changed the title cloak: move to by-name misc packages: move to by-name Nov 21, 2024
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357828


x86_64-linux


aarch64-linux


x86_64-darwin


aarch64-darwin

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git history is messy.

@Aleksanaa Aleksanaa changed the title misc packages: move to by-name treewide: move to by-name Nov 22, 2024
@Aleksanaa Aleksanaa merged commit 8edf06b into NixOS:master Nov 22, 2024
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants