makes symlinks for wgpu-native library where odin expects #365445
+22
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Odin expects the backing libraries for its
vendor
packages to exist in specific locations. For wgpu specifically, it defaults to using the static build of wgpu-native.This PR adds a flag to the odin package which, when enabled, includes the correct version of wgpu-native and symlinks the library files to the locations that odin expected.
I also removed a line in wgpu-native which deleted the static wgpu-native library. It's built along with the shared library anyway. I can put that change behind a flag as well, if needed.
These changes are specifically for linux and scoped as such.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.