Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async support for cluster nodes call #123

Closed
rahulKrishnaM opened this issue Dec 14, 2022 · 1 comment · Fixed by #171
Closed

Async support for cluster nodes call #123

rahulKrishnaM opened this issue Dec 14, 2022 · 1 comment · Fixed by #171

Comments

@rahulKrishnaM
Copy link

Hi,

cluster_update_route_by_addr() function today invokes a 'cluster nodes' command and waits synchronously till the response is available. Since its a blocking call, and hiredis context is single threaded, all other operations go for a halt till the response is received. This impacts the performance of the system, since all other calls application uses are async implemented, and any code flow that reaches here has to wait till the call gets over.

This ticket is a request for an async implementation for supporting the cluster nodes/slots command.

Thanks.

@zuiderkwast
Copy link
Collaborator

Hi! We now use an asynchronous command for cluster nodes/slots when we see a MOVED-redirect, added in #164, but the initial connect is still blocking. It is being worked on in #171. Feel free to join the discussion if you have any suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants