-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redisClusterAsyncConnect2() #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Some comments and thoughts mainly about documentation.
redisClusterAsyncConnect2() uses non-blocking sockets to get the initial slotmap in comparison to redisClusterAsyncConnect() which uses the blocking API internally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just some comments on text.
Co-authored-by: Viktor Söderqvist <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is ready to merge?
Adds a new public function
redisClusterAsyncConnect2()
which uses the attached event engine to get the initial slot map asynchronously compared to the legacy functionredisClusterAsyncConnect()
which is a blocking call.Closes #123