Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redisClusterAsyncConnect2() #171

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Add redisClusterAsyncConnect2() #171

merged 8 commits into from
Aug 29, 2023

Conversation

bjosv
Copy link
Collaborator

@bjosv bjosv commented Jun 21, 2023

Adds a new public function redisClusterAsyncConnect2() which uses the attached event engine to get the initial slot map asynchronously compared to the legacy function redisClusterAsyncConnect() which is a blocking call.

Closes #123

@bjosv bjosv requested a review from zuiderkwast June 21, 2023 17:30
Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Some comments and thoughts mainly about documentation.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hircluster.h Outdated Show resolved Hide resolved
hircluster.c Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
redisClusterAsyncConnect2() uses non-blocking sockets to get the initial slotmap
in comparison to redisClusterAsyncConnect() which uses the blocking API internally.
@bjosv bjosv marked this pull request as ready for review August 25, 2023 09:56
Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just some comments on text.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Co-authored-by: Viktor Söderqvist <[email protected]>
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is ready to merge?

@bjosv bjosv merged commit 2680113 into Nordix:master Aug 29, 2023
32 checks passed
@bjosv bjosv deleted the async-connect2 branch August 29, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async support for cluster nodes call
2 participants