Add events "ready" and "free context" and add event privdata. #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuiderkwast
force-pushed
the
event-started
branch
from
424bb5e
to
4e96f70
Compare
bjosv
reviewed
Aug 23, 2023
zuiderkwast
changed the title
bjosv
reviewed
Aug 23, 2023
The event callback is changed to take an extra argument, which is a change to the unreleased event callback feature.
zuiderkwast
force-pushed
the
event-started
branch
from
e8ad5da
to
8219dc8
Compare
Co-authored-by: Bjorn Svensson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event callback is changed to take an extra argument, which is a change to the unreleased event callback feature.
The two new events are
HIRCLUSTER_EVENT_READYwhen the slot mapping has been fetched for the first time and the client is ready to accept commands;HIRCLUSTER_EVENT_FREE_CONTEXTwhen the cluster context is being freed, so that the user can free the event privdata.