Add cluster scale down test #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covers new behaviour of updating slotmap due to error.
zuiderkwast
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Nice!
Though I don't fully understand which parts of this test case cover the pipelined (AKA deferred) slotmap update using cc->need_update_route and which parts cover the synchronous cluster_update_route() (called on connect failure). Maybe some more comments in the test case can help.
zuiderkwast
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new testcase covers the new behaviour of updating slotmap due to error in sync API (#182).
Adapted from #87.