Update connect-error-using-cluster-nodes-test #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use clusterclient for this testcase instead of clusterclient_async since the testcase aims to test failures in the initial *blocking* slotmap update. clusterclient now also handles the flag `--use-cluster-nodes` to update the slotmap using the command "CLUSTER NODES".
Let connect error logs be printed to stdout since this step is part of the testcase.
bjosv
force-pushed
the
update-connect-error-test
branch
from
722c91b
to
510162c
Compare
zuiderkwast
reviewed
Sep 1, 2023
zuiderkwast
reviewed
Sep 4, 2023
zuiderkwast
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use clusterclient for this testcase instead of clusterclient_async since
the testcase aims to test failures in the initial blocking slotmap update.
clusterclient now also handles the flag
--use-cluster-nodesto updatethe slotmap using the command "CLUSTER NODES".