Include the dataset_description.json as output #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per version 1.2.x BIDS specification states that a BIDS-compliant dataset MUST include the compulsory file
dataset_description.json
. See Section 03 (Modality agnostic files) of the BIDS specification.This small PR ensures that the
xnat2bids.py
script copies thedataset_description.json
JSON file stored in the BIDS resource into the output directory (if present).The hereby proposed fix shall permit container-service using the
xnat2bids
setup-command to run up-to-date BIDS apps. Otherwise, BIDS apps might fail running due to invalid BIDS datasets, e.g. see error below runningpoldracklab/mriqc:0.15.1
container with current setting:For easy deployment, changes should be propagated in the creation of a new version of the
xnat2bids-setup
docker image at Docker Hub.