[MIG] sale_order_line_sequence: Migration to 18.0 #3433

BT-mchechlacz · 2024-11-26T10:37:17Z

No description provided.

* sale_order_line_sequence v10 * OCA Transbot updated translations from Transifex * Update sale_order_line_sequence.pot * Translated using Weblate (Portuguese) Currently translated at 100,0% (6 of 6 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_order_line_sequence/pt/ * sale_order_line_sequence: migration to 11.0 * Update sale_order_line_sequence.pot * [MIG] sale_order_line_sequence v12

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_sequence/es/

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_sequence/de/

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_sequence/zh_CN/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_line_sequence/

Currently translated at 25.0% (2 of 8 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_line_sequence/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_sequence/

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_sequence/es/

…for orders and invoices

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_sequence/

Currently translated at 100.0% (10 of 10 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_sequence/es/

Currently translated at 100.0% (10 of 10 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_sequence/it/

Currently translated at 100.0% (10 of 10 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_sequence/pt_BR/

Currently translated at 70.0% (7 of 10 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_order_line_sequence/fr/

Currently translated at 100.0% (10 of 10 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_order_line_sequence/fr/

BT-crodriguez

LGTM just some licenses missing

BT-crodriguez · 2024-11-26T12:36:42Z

sale_order_line_sequence/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_sale_order_line_sequence


[change] Missing license header

# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).

@BT-crodriguez License headers are not needed in __init__.py files.

BT-crodriguez · 2024-11-26T12:41:36Z

sale_order_line_sequence/views/account_move_view.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="utf-8" ?>


[change] Missing license header

<?xml version="1.0" encoding="utf-8" ?>

Are licenses needed in each file? https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst only mentions the manifest.

BT-crodriguez · 2024-11-26T12:41:54Z

sale_order_line_sequence/views/report_invoice.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8" ?>


[change] Missing license header

<?xml version="1.0" encoding="utf-8" ?>

BT-crodriguez · 2024-11-26T12:43:12Z

sale_order_line_sequence/views/report_saleorder.xml

@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="utf-8" ?>


[change] Missing license header

BT-crodriguez · 2024-11-26T12:43:26Z

sale_order_line_sequence/views/sale_view.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8" ?>


[change] Missing license header

rousseldenis · 2024-11-26T12:46:44Z

/ocabot migration sale_order_line_sequence

StefanRijnhart · 2024-12-04T14:26:16Z

sale_order_line_sequence/models/account_move_line.py

+    @api.depends("move_id.invoice_line_ids")
+    def _compute_related_so_sequence(self):
+        for rec in self:
+            if len(rec.mapped("move_id.line_ids.sale_line_ids.order_id")) > 1:


Given that you are touching this line in the migration commit, better go all the way with

Suggested change

if len(rec.mapped("move_id.line_ids.sale_line_ids.order_id")) > 1:

if len(rec.move_id.line_ids.sale_line_ids.order_id) > 1:

StefanRijnhart · 2024-12-04T14:30:22Z

sale_order_line_sequence/views/report_saleorder.xml

+        id="report_saleorder_document_sequence"
+        inherit_id="sale.report_saleorder_document"
+    >
+        <xpath expr="//table[hasclass('table')]/thead/tr/th[1]" position="before">


Can you make the table selection more specific? I see multiple tables with this class in the document. I think each does have a unique class that you can add here.

StefanRijnhart · 2024-12-04T14:30:55Z

sale_order_line_sequence/__manifest__.py

+{
+    "name": "Sale Order Line Sequence",
+    "summary": "Propagates SO line sequence to invoices and stock picking.",
+    "version": "18.0.1.1.0",


Suggested change

"version": "18.0.1.1.0",

"version": "18.0.1.0.0",

StefanRijnhart · 2024-12-04T14:34:45Z

sale_order_line_sequence/views/sale_view.xml

+        <field name="inherit_id" ref="sale.view_order_form" />
+        <field name="arch" type="xml">
+            <field name="order_line" position="before">
+                <field name="max_line_sequence" invisible="1" />


Fields like this, that will never be visible and are only used in attributes of other fields are now added automatically in Odoo 18. I think we can consider removing them from our views for a slightly cleaner layout. What do you think?

I only added this to the migration guidelines yesterday, so you will not have seen it before.

Missing fields used in domains and other attributes are added to the view as invisible automatically. If you encounter fields in views with invisible="True", they can probably be removed. Reference: odoo/odoo#137031

nikul-serpentcs and others added 30 commits November 26, 2024 11:35

[UPD] Update sale_order_line_sequence.pot

80eb2aa

Update translation files

fffef70

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[IMP] sale_order_line_sequense: black, isort

80f0e21

[MIG] sale_order_line_sequence: Migration to 13.0

950a239

[UPD] Eficent -> ForgeFlow

82f8813

[MIG] sale_order_line_sequence: Migration to 14.0

c0554ee

[MIG] sale_order_line_sequence: Migration to 15.0

5ddea4b

[UPD] README.rst

5aa9194

[IMP] sale_order_line_sequence: pre-commit stuff

7ca3966

add optional on sequence field in xml

ce73aa0

[IMP] sale_order_line_sequence: module refactor, new sequence fields …

2a81eee

…for orders and invoices

[MIG] sale_order_line_sequence: Migration to 17.0

3f07901

[UPD] Update sale_order_line_sequence.pot

48237d8

[IMP] linting changes to .rst files

0fa024d

[IMP] sale_order_line_sequence: attrs removed

2e6d0d7

[IMP] sale_order_line_sequence: pre-commit auto fixes

a53bda8

BT-mchechlacz force-pushed the 18.0-mig-sale_order_line_sequence branch 2 times, most recently from 9daae73 to 4877de4 Compare November 26, 2024 10:51

[MIG] sale_order_line_sequence: Migration to 18.0

e8ed45b

BT-mchechlacz force-pushed the 18.0-mig-sale_order_line_sequence branch from 4877de4 to e8ed45b Compare November 26, 2024 10:52

BT-nfrancisco approved these changes Nov 26, 2024

View reviewed changes

BT-crodriguez suggested changes Nov 26, 2024

View reviewed changes

rousseldenis added needs review migration labels Nov 26, 2024

OCA-git-bot added this to the 18.0 milestone Nov 26, 2024

OCA-git-bot mentioned this pull request Nov 26, 2024

Migration to version 18.0 #3344

Open

47 tasks

StefanRijnhart reviewed Dec 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] sale_order_line_sequence: Migration to 18.0 #3433

[MIG] sale_order_line_sequence: Migration to 18.0 #3433

BT-mchechlacz commented Nov 26, 2024

BT-crodriguez left a comment

BT-crodriguez Nov 26, 2024

rousseldenis Nov 26, 2024

BT-crodriguez Nov 26, 2024

StefanRijnhart Dec 4, 2024

BT-crodriguez Nov 26, 2024

BT-crodriguez Nov 26, 2024

BT-crodriguez Nov 26, 2024

rousseldenis commented Nov 26, 2024

StefanRijnhart Dec 4, 2024

StefanRijnhart Dec 4, 2024

StefanRijnhart Dec 4, 2024

StefanRijnhart Dec 4, 2024

	if len(rec.mapped("move_id.line_ids.sale_line_ids.order_id")) > 1:
	if len(rec.move_id.line_ids.sale_line_ids.order_id) > 1:

[MIG] sale_order_line_sequence: Migration to 18.0 #3433

Are you sure you want to change the base?

[MIG] sale_order_line_sequence: Migration to 18.0 #3433

Conversation

BT-mchechlacz commented Nov 26, 2024

BT-crodriguez left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis commented Nov 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment