Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to manually trigger a workflow + run only on PR and master push #317

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

atsju
Copy link
Collaborator

@atsju atsju commented Mar 11, 2023

this will also help find if #315 fails or master

@atsju atsju requested a review from Hish15 March 11, 2023 13:50
@atsju atsju changed the title add ability to manually trigger a workflow add ability to manually trigger a workflow + run only on PR and master push Mar 11, 2023
Copy link
Collaborator

@Hish15 Hish15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You pushed 2 commits intead of one here

@@ -1,6 +1,8 @@
cmake_minimum_required(VERSION 3.16)
set(CMAKE_TOOLCHAIN_FILE ${CMAKE_CURRENT_SOURCE_DIR}/../../cmake/stm32_gcc.cmake)

set(STM32_CUBE_F4_PATH "C:\\GIT\\STM32CubeF4")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the stm32_fetch_cube(F4) function, in the if stm32_fetch_cube(F4) instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not supposed to be pushed. It slipped though on commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants