add CMSIS DSP library target to FindCMSIS.cmake #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hish15
reviewed
Oct 3, 2024
| @@ -313,6 +313,13 @@ foreach(COMP ${CMSIS_FIND_COMPONENTS_FAMILIES}) | |||
| set(CMSIS_${RTOS_COMP}_FOUND TRUE) | |||
| endforeach() | |||
|
|
|||
| if(NOT (TARGET CMSIS::STM32::${FAMILY}${CORE_C}::DSP})) | |||
There was a problem hiding this comment.
At this point, do you know for sure that we do have the DSP for all families ? otherwise we might want to check first
There was a problem hiding this comment.
Hi @Hish15,
Sorry for taking so long to respond on this one. I went through and validated that every family has the ability to pull in DSP. Would you like me to write a unit test to make sure this remains the case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a target to the
FindCMSIS.cmakethat allows you to bring in the CMSIS DSP library for a given target. The targets end up looking likeCMSIS::STM32::H7::M7::DSPas an example.Let me know if there's anything you'd like me to tweak about this, otherwise it's a pretty simple change I think.