Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Safari Extension #4722

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Sam-Spencer
Copy link

Changes

  • Adds support for a Safari Extension, as requested in Safari Version #2344
    • Available for iOS and macOS
  • Minor improvements to the styling for the options / settings page
    • Support for system-defined dark mode
    • Now uses the default system-provided font for UI elements

Notes

The included Safari extension requires Xcode to build, compile, and distribute. Because Safari extensions must be distributed as part of an app bundle, the extension must also be code-signed. On macOS, the extension will need to be notarized in order to install and run without showing warnings to users. @OhMyGuus let me know if you need a hand with any of this.

@Sam-Spencer Sam-Spencer mentioned this pull request May 30, 2023
@krystian3w
Copy link

You forgot to do an installation guide bypassing the app store on iOS (IMO the hardest) and the Apple Store on macOS.

You can make them in a similar format to the readme.md file.

@OhMyGuus
Copy link
Owner

Wow, really amazing work and really appreciated.

Going to try to install this asap on a VM and see if it is all working.
After that I will merge it & buy a developer certificate, I might need some help after that to see how the publishing steps are since it's my first time releasing something for a mac and I currently don't own any apple devices except an old iphone 6 so might need help with that after.
But will give updates about this here :)

@ann0see
Copy link

ann0see commented May 31, 2023

I'd be happy testing. I own a 1st gen iPhone SE but don't have reliable access to a Mac.

@ann0see
Copy link

ann0see commented May 31, 2023

You forgot to do an installation guide bypassing the app store on iOS (IMO the hardest) and the Apple Store on macOS.

I believe this can be linked to https://support.apple.com/en-gb/guide/mac-help/mh40616/mac for macOS and for iOS it might change with iOS 17 - at least in the EU. Practically speaking, iOS sideloading is nothing for the average user at the moment. Developers can be linked to e.g sideloadly.

It seems as if the AppStore deployment isn't a blocker anyway.

@Sam-Spencer
Copy link
Author

@OhMyGuus I have an Apple Developer account and would be happy to get the binary notarized (signed) if that's something you're interested in (if so, feel free to reach me at hello[at]samspencer[dot]art)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants