-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 0.1.0-alpha.5 #14
release: 0.1.0-alpha.5 #14
Conversation
Stainless Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great! I have a few questions which may just show my Java ignorance. I honestly don't know.
id("java") | ||
} | ||
|
||
group = "org.example" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be org.onebusaway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yes, that makes sense
.baseUrl(BASE_URL) | ||
.build(); | ||
|
||
public static void main(String[] args) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what an incredibly tedious language 😆 thanks for powering through this :)
@@ -0,0 +1,39 @@ | |||
package org.example; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should all of these packages be org.onebusaway.example
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have updated all the package names now.
aec3bef
to
3409162
Compare
f2d5320
to
782ab17
Compare
🤖 Release is at https://github.com/OneBusAway/java-sdk/releases/tag/v0.1.0-alpha.5 🌻 |
Automated Release PR
0.1.0-alpha.5 (2024-10-04)
Full Changelog: v0.1.0-alpha.4...v0.1.0-alpha.5
Features
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions