Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Death Mountain cloud color checks for Volvagia Blue Warp flag #1901

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Feb 24, 2023

The cloud around Death Mountain has a flag to tell if it should be red (before killing Volvagia) or white (after).
This flag is set during one of the cutscenes after killing Volvagia, but since this cutscene is skipped in rando, the flag is never set and the cloud always stays red.
This change make it check instead for the "Took Volvagia blue warp", to ensure the correct color change.

This has a tiny drawback : the cutscene where this change take place is not fully skipped, and since the blue warp flag is set before it, the cloud will now be white instead of red during what is left of the cutscene.
But it's incorrect during one second and correct for the rest of the game, so overall it's more correct !

@fenhl
Copy link
Collaborator

fenhl commented Feb 24, 2023

the cutscene where this change take place is not fully skipped, and since the blue warp flag is set before it, the cloud will now be white instead of red during what is left of the cutscene.

This cutscene will be fully skipped once dungeon reward shuffle (#1833) lands (PR soon™) so even this minor issue will be temporary.

@GSKirox
Copy link
Collaborator Author

GSKirox commented Feb 24, 2023

Oh nice !

@Cuphat Cuphat added the Component: ASM/C Changes some internals of the ASM/C libraries label Feb 24, 2023
@engineer124
Copy link

For reference, here's the specific line that sets this flag in the new implementation of blue warps designed for dungeon reward shuffle (the one that skips all cutscenes):
https://github.com/fenhl/OoT-Randomizer/blob/7a851fdf618880b456c6431ccd55bc695767f54d/ASM/c/blue_warp.c#L85

@GSKirox
Copy link
Collaborator Author

GSKirox commented Feb 26, 2023

Oh i wasn't aware dungeon reward shuffle completely fixed it 😅
Then yeah this PR will be completely useless once it gets in, since it sets the cloud flag properly.

@Cuphat Cuphat merged commit 565a5a8 into OoTRandomizer:Dev Feb 27, 2023
@GSKirox GSKirox deleted the dmt_cloud_flag branch February 28, 2023 07:06
@fenhl fenhl added this to the 8.0 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ASM/C Changes some internals of the ASM/C libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants