Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering documents #1142

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

sebojolais
Copy link
Contributor

Implements this feature request: #1141

Add a lineedit to filter the documents list.

Copy link
Collaborator

@letsfindaway letsfindaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I have a few comments. Please have a look at them.

src/document/UBSortFilterProxyModel.cpp Outdated Show resolved Hide resolved
src/document/UBSortFilterProxyModel.h Outdated Show resolved Hide resolved
src/document/UBSortFilterProxyModel.cpp Outdated Show resolved Hide resolved
src/document/UBDocumentController.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@letsfindaway letsfindaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR.

@sebojolais
Copy link
Contributor Author

The last commit implements the deletion of the filter linedit when we switch to the document mode, in order to reduce the risk explained here:

If the user types a string in the filter line edit and he forgets it and his action. So he will get a shorter list of documents that could leads him to think some documents are lost.

For information, it is tested on Linux Ubuntu 22.04 with Qt5 and Qt 6.7 with success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants