Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused files #1163

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

letsfindaway
Copy link
Collaborator

@letsfindaway letsfindaway commented Nov 12, 2024

This PR just removes a set of files which is no longer referenced by the project anywhere.

When looking though the code, I was quite often stumbling over these files. Just during my work on PR #1162 I very often searched for a symbol through the code. Especially for signals and slots using the SIGNAL(name()) and SLOT(name()) syntax the cross-referencing of these function names does not work, so I had to use string search. Often the results then contained lines in these obsolete files.

Removing these files from the current branch makes maintenance easier and does not change the application in any way.

  • remove src/gui/UBDocumentTreeWidget.cpp/.h
    replaced by UBDocumentTreeView contained in UBDocumentController at 2018-08-18
  • remove src/gui/UBDocumentNavigator.cpp/.h
    replaced by UBBoardThumbnailsView at 2017-09-24
  • remove src/customWidgets
    not referenced by the OpenBoard.pro file since creation at 2013-06-21
  • remove plugins/cffadaptor unused files
    UBCFFAdaptor.pro, postScript_mac.sh, resoures/* originally used to build standalone plugin
  • remove src/domain/UBDragableThumbnail.cpp/.h
    not referenced in the project files, added in 2017-09-24, but never added to any .pri file

- remove src/gui/UBDocumentTreeWidget.cpp/.h
  replaced by UBDocumentTreeView contained in UBDocumentController
  at 2018-08-18
- remove src/gui/UBDocumentNavigator.cpp/.h
  replaced by UBBoardThumbnailsView at 2017-09-24
- remove src/customWidgets
  not referenced by the OpenBoard.pro file since creation at 2013-06-21
- remove plugins/cffadaptor unused files
  - UBCFFAdaptor.pro, postScript_mac.sh, resoures/*
  originally used to build standalone plugin
- remove src/domain/UBDragableThumbnail.cpp/.h
  not referenced in the project files
  added in 2017-09-24, but never added to any .pri file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant