Feat: rotate snap indicator and snap rotated items #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add optional angle parameter - use painter rotation to draw triangle at any angle
- snap rotated item when moving w/o delegate frame - snap rotated item when moving by delegate frame - snap resizing for rotation angles 0 / 90 / 180 / 270 - snap newly drawn rotated line at line end points instead of outline
letsfindaway
force-pushed
the
feat-rotate-snap-indicator
branch
from
8e8aacd to
55a2144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the snap-to-grid function correctly to rotated items. It tries to make snapping more foreseeable and toi better fit user expectations for rotated items.
See also letsfindaway#185 for a discussion of this feature and the list of tests I have conducted.