Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The grid size is now stored in the configuration. #894

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

habruening
Copy link

At startup of the application, the grid is calculated differently on different systems. The intended behaviour is that 1cm on screen is one grid space. That works perfectly. But in practice this is not often needed. And unfortunately the behaviour has a negative side effect: If you open the same file on different systems with different screen configurations (which is a typical use case for teachers), and create new pages, these pages get a another grid size than the already existing pages. That is a bit confusing. And especially when the ruler is used the behaviour is not nice, because on different systems it measures different sizes.

I propose to change the behaviour as follows.

The grid size is remembered. The grid size changes only when the user explicitly sets a new value with the slider. At next startup this value is kept. The nice 1cm calculation only happens when the user clicks on the "set default size" button. The start value for the grid is 40, because that value should be comfortable for most people.

I implemented this. The code simplifies a bit, because now we don't have to store the default value any more. Interestingly the connection to the signal UBDisplayManager::screenRolesAssigned becomes obsolete. It makes no sense any more to automatically update the grid size, when the screen configuration changes.

The 1cm grid calculation happens only when the reset grit button is pressed, but not automatically.
@ThomasLucky13
Copy link
Contributor

Hello! A similar solution to the problem has already been proposed earlier in this PR: #712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants