#806 Support custom ClassLookup in WireTypeConverter #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenp
force-pushed
the
#806-Support-custom-ClassLookup-in-WireTypeConverter
branch
from
95d5159
to
05fa50e
Compare
|
@maxim-ponomarev I've adjusted the test (as per |
yevgenp
force-pushed
the
#806-Support-custom-ClassLookup-in-WireTypeConverter
branch
from
05fa50e
to
609b4be
Compare
yevgenp
reviewed
Jan 30, 2024
|
|
||
| public class UnknownClassLookup implements ClassLookup { | ||
| public static final CachedCompiler CACHED_COMPILER = | ||
| new CachedCompiler(Jvm.isDebug() ? new File(OS.getTarget(), "generated-test-sources") : null, null); |
There was a problem hiding this comment.
This class should be moved to test sources or target has to be adjusted respectively.
|
|
c.f. #823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.