Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ohm-website - production #223

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Update ohm-website - production #223

merged 1 commit into from
Aug 17, 2023

Conversation

Rub21
Copy link
Collaborator

@Rub21 Rub21 commented Aug 16, 2023

Update overpass gitsha

Update node version

Update clean cache for overpass
@danrademacher
Copy link
Member

hmm, so the Overpass Turbo build failed, but the rest worked. So I would expect the latest code to be on the live site.

However, I am not seeing the latest code on Production. It's rather subtle since the map style changes impact data that does not existing on Staging, but I can see these differences from latest commit to staging to production:

  1. this line was changed in the style: OpenHistoricalMap/ohm-website@1ec64f0#diff-d78f859eea47d9af4acf39acdb70466f8cc734a2ef478c9cdcc053b4eda8533bR1155 from water_lines_stream to water_lines_stream_no_name
  2. On staging, if I open the minified application JS and search for that string, I get a result:
    image
  3. But on production if I search the prod version of the same JS file, I get no result.

And the streams on prod are in fact still showing labels without lines:
image
where what we expect to see is no labels until we have streams, like this
image

@danrademacher
Copy link
Member

Oh wait, this won't actually deploy until we merge this PR into main. OK, been a little while since I was closely tracking a deploy here.

So @Rub21 not sure what to do about the failed Overpass Turbo deploy. I am not aware of anything changing there.

@danrademacher danrademacher merged commit 20a2f68 into main Aug 17, 2023
3 of 4 checks passed
@danrademacher
Copy link
Member

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants