Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2.0.0 - MPhys Variable Naming Convention Classes #181

Merged
merged 48 commits into from
Dec 11, 2024
Merged

V2.0.0 - MPhys Variable Naming Convention Classes #181

merged 48 commits into from
Dec 11, 2024

Conversation

kejacobson
Copy link
Collaborator

@kejacobson kejacobson commented Sep 16, 2024 •
edited
Loading

  • Waiting until December 2nd to merge to avoid major changes while people work on SciTech papers

ToDo:

  • Update documentation

kejacobson and others added 30 commits May 15, 2023 10:35
@kejacobson
Start of variable convention class
1307469
@kejacobson
Change variable naming convention to nested classes by discipline
f3d5ddc
@kejacobson
Switch variable names to all caps.
f84f8b6 
Split aero into surface anticipating volume coupling at some point down the road
@kejacobson
Merge branch 'main' into naming_convention_class
a1c680c
@kejacobson
Reorganize files based on 2024-04-01 telecon discussion. More usage o…
2499083 
…f the naming convention classes throughout the tests
@kejacobson
Remove FUN3D examples
139ed1a
@kejacobson
Cannot use MultiPoint's mphys_connect_scneario_coordinate_source anym…
42f7ceb 
…ore since the geometry and mesh sources are no longer the same name.
@kejacobson
Consistent capitalization of MPhys in class names: MphysGroup -> MPhy…
a4be934 
…sGroup
@kejacobson
Missed a file from previous commit
cdb3f27
@kejacobson
Temporarily add thermal as a class in structures
069c263
@kejacobson
Make sure geo comes before aero_pre in aerostruct cases with "aerodyn…
5867fff 
…amics only" coupling option
@kejacobson
In the fake aerodynamics for testing, the aero_pre component should u…
74e269d 
…se the initial coordinates, not the deformed coordinates
@kejacobson
Update thermal convention to be a separate discipline instead of a su…
07d9caa 
…bdiscipline of structures
@kejacobson
Merge branch 'main' into naming_convention_class
a7048d1
@kejacobson
update MPhysGroup docs to new name
ee74529
@kejacobson
Get rid of GeoOnly and just do two connections from the user side
399381e
@kejacobson
Merge pull request #149 from kejacobson/naming_convention_class
c295677 
Naming convention class
@timryanb
Update setup.py
041728d
@timryanb
Breaking out Structures and Thermal load vars into sub-class
a5b3ffd
@timryanb
Adding new distributed sumer component
b6dbd6f
@timryanb
Adding mphys_connect_scenario_coordinate_source method back in
0aa56f8
@timryanb
Updating unit tests
5e8d0f6
@timryanb
Updating more unit tests
ea42a63
@timryanb
renaming summer component
cc4f650
@timryanb
Fixing name in test script
8d154a1
@timryanb
Removing mphys_connect_scenario_coordinate_source from multipoint
d35d93a
@kejacobson
Merge pull request #176 from timryanb/v2.0.0_var_mod
bac2135 
Breaking out Structures and Thermal load vars into sub-class
@kejacobson
Make setup() in scenario switch directory (if set)
108ec31
@kejacobson
Merge pull request #180 from kejacobson/switch_dir_setup
a2bd8c6 
Make setup() in scenario switch directory if set
@timryanb
Removing unnecessary from distributed converter.
9eb4ae6
kejacobson and others added 10 commits December 10, 2024 10:29
@kejacobson kejacobson changed the title Draft: V2.0.0 - MPhys Variable Naming Convention Classes V2.0.0 - MPhys Variable Naming Convention Classes Dec 11, 2024
@kejacobson kejacobson requested a review from Asthelen December 11, 2024 13:06
@kejacobson kejacobson mentioned this pull request Dec 11, 2024
Open
3 tasks
timryanb and others added 2 commits December 11, 2024 09:32
@timryanb
bumping required version for all recomended dependencies in README to…
e9ba939 
… next realease
@kejacobson
Merge pull request #189 from timryanb/readme-vers-bump
54a23e7 
bumping required version for all recomended dependencies in README
Asthelen
Asthelen requested changes Dec 11, 2024
View reviewed changes
docs/basics/model_assembly.rst Outdated Show resolved Hide resolved
docs/basics/builders.rst Outdated Show resolved Hide resolved
docs/basics/model_assembly.rst Outdated Show resolved Hide resolved
docs/basics/model_hierarchy.rst Outdated Show resolved Hide resolved
docs/basics/model_hierarchy.rst Outdated Show resolved Hide resolved
docs/basics/model_hierarchy.rst Outdated Show resolved Hide resolved
kejacobson and others added 6 commits December 11, 2024 12:25
@kejacobson @Asthelen
Docs tries->seeks
bde1b3c 
Co-authored-by: Andrew Thelen <[email protected]>
@kejacobson @Asthelen
Add missing word in Docs sentence
9d64909 
Co-authored-by: Andrew Thelen <[email protected]>
@kejacobson @Asthelen
docs typo
4592c7d 
Co-authored-by: Andrew Thelen <[email protected]>
@kejacobson @Asthelen
docs typo - missing "be"
e89eb23 
Co-authored-by: Andrew Thelen <[email protected]>
@kejacobson @Asthelen
Docs - improved wording and fix misspelling
24849c5 
Co-authored-by: Andrew Thelen <[email protected]>
@kejacobson @Asthelen
Docs typo
a50a797 
Co-authored-by: Andrew Thelen <[email protected]>
@kejacobson kejacobson requested a review from Asthelen December 11, 2024 17:30
@kejacobson kejacobson merged commit 60abb43 into main Dec 11, 2024
1 check passed
@kejacobson kejacobson deleted the v2.0.0_beta branch December 11, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Asthelen Asthelen Asthelen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kejacobson @Asthelen @timryanb