Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mach #59

Merged
merged 24 commits into from
Apr 13, 2021
Merged

Refactor mach #59

merged 24 commits into from
Apr 13, 2021

Conversation

anilyil
Copy link
Collaborator

@anilyil anilyil commented Apr 1, 2021

This PR moves the mdolab wrappers and examples to the new refactored version. @joanibal please take a look at these and test your thermal work. I will check all of the examples and tests again locally. I also formatted all of the relevant files I touched.

@anilyil
Copy link
Collaborator Author

anilyil commented Apr 1, 2021

All of the tests except these two pass locally:

The following tests failed:
test_meld_derivs.py:TestXferClasses.test_derivatives
test_tacs_derivs.py:TestTACs.test_derivatives

This is probably because I didnt do the complex installation properly. Let me know if I can fix my installation and I can try again.

@kejacobson
Copy link
Collaborator

For both meld and tacs, you can do make clean && make complex && make complex_interface to run those tests.

@joanibal
Copy link
Collaborator

Do the Tacs tests pass now @anilyil?

Don't worry about the thermal stuff. I use my own dev branch of MPHYS (which has changes incompatible with the main code) for that work.

@anilyil
Copy link
Collaborator Author

anilyil commented Apr 13, 2021

sorry for the delayed response, I compiled complex tacs and meld and those final two tests pass locally for me as well. I will review the changes here quickly again and merge this PR later today.

@anilyil
Copy link
Collaborator Author

anilyil commented Apr 13, 2021

All tests and example scripts run fine now. There are a few items I did not do in this PR, and to track those issues, I opened #61, #62, and #63. I will address those one by one in future PRs. This one is good to go.

@anilyil anilyil merged commit 392b4fa into OpenMDAO:master Apr 13, 2021
@anilyil anilyil deleted the refactor_mach branch April 13, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants